]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: iwlwifi: mld: check for NULL pointer after kmalloc
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Sun, 19 Oct 2025 08:45:16 +0000 (11:45 +0300)
committerMiri Korenblit <miriam.rachel.korenblit@intel.com>
Tue, 28 Oct 2025 14:17:27 +0000 (16:17 +0200)
Coverity complained that we didn't add a NULL check for the link we
allocate.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20251019114304.d1f958160c5a.Icc891c14c633c3b8625372680fdc67ca33c83cc7@changeid
drivers/net/wireless/intel/iwlwifi/mld/link.c

index deb1e7227dd85844ce3fe0988c5bedc833587c62..27ae8bd6f407c6164c3f0482dad3b79433f5c1c7 100644 (file)
@@ -465,10 +465,13 @@ int iwl_mld_add_link(struct iwl_mld *mld,
        int ret;
 
        if (!link) {
-               if (is_deflink)
+               if (is_deflink) {
                        link = &mld_vif->deflink;
-               else
+               } else {
                        link = kzalloc(sizeof(*link), GFP_KERNEL);
+                       if (!link)
+                               return -ENOMEM;
+               }
        } else {
                WARN_ON(!mld->fw_status.in_hw_restart);
        }