]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: mdio: mdio-bcm-unimac: Refine incorrect clock message
authorFlorian Fainelli <florian.fainelli@broadcom.com>
Mon, 11 Aug 2025 16:59:21 +0000 (09:59 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 13 Aug 2025 00:16:20 +0000 (17:16 -0700)
In light of a81649a4efd3 ("net: mdio: mdio-bcm-unimac: Correct rate
fallback logic"), it became clear that the warning should be specific to
the MDIO controller instance, and there should be further information
provided to indicate what is wrong, whether the requested clock
frequency or the rate calculation. Clarify the message accordingly.

Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20250811165921.392030-1-florian.fainelli@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/mdio/mdio-bcm-unimac.c

index 7baab230008a42937e0d58d22ea6128807400ab0..37e35f282d9ad808d06578926e96f76cb2f2fd84 100644 (file)
@@ -215,7 +215,9 @@ static int unimac_mdio_clk_set(struct unimac_mdio_priv *priv)
 
        div = (rate / (2 * priv->clk_freq)) - 1;
        if (div & ~MDIO_CLK_DIV_MASK) {
-               pr_warn("Incorrect MDIO clock frequency, ignoring\n");
+               dev_warn(priv->mii_bus->parent,
+                        "Ignoring MDIO clock frequency request: %d vs. rate: %ld\n",
+                        priv->clk_freq, rate);
                ret = 0;
                goto out;
        }