]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
test/ct_test.c: Add the missing check after calling sk_SCT_new_null
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Mon, 24 Jan 2022 03:18:38 +0000 (11:18 +0800)
committerTomas Mraz <tomas@openssl.org>
Tue, 25 Jan 2022 17:15:22 +0000 (18:15 +0100)
As the potential failure of the allocation, the sk_SCT_new_null() could
return NULL pointer if fails.
And then sk_SCT_push() uses the 'fixture->sct_list' and returns -1 if
fails.
But the return value of the sk_SCT_push() is not checked.
I think it is better to check it just after the allocation.

CLA: trivial

Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/17571)

test/ct_test.c

index d1799fa7a236834cc20651f29d64df438e4e339f..f914ee514a0dc29a60e873fc2ca216c68d9d403d 100644 (file)
@@ -449,6 +449,9 @@ static int test_encode_tls_sct(void)
     SETUP_CT_TEST_FIXTURE();
 
     fixture->sct_list = sk_SCT_new_null();
+    if (fixture->sct_list == NULL)
+           return 0;
+
     if (!TEST_ptr(sct = SCT_new_from_base64(SCT_VERSION_V1, log_id,
                                             CT_LOG_ENTRY_TYPE_X509, timestamp,
                                             extensions, signature)))