]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
RISC-V: Prohibit the 'Zcf' extension on RV64
authorTsukasa OI <research_trasio@irq.a4lg.com>
Mon, 24 Jul 2023 05:01:12 +0000 (05:01 +0000)
committerTsukasa OI <research_trasio@irq.a4lg.com>
Mon, 24 Jul 2023 23:42:35 +0000 (23:42 +0000)
As per:
<https://github.com/riscv/riscv-code-size-reduction/issues/221>,
the 'Zcf' extension does not exist on RV64.  This is reflected on the
version 1.0.4-1 of the code size reduction specification:
<https://github.com/riscv/riscv-code-size-reduction/releases/tag/v1.0.4-1>.

This commit prohibits the combination: RV64 (or any ISA with XLEN > 32)
and the 'Zcf' extension.

bfd/ChangeLog:

* elfxx-riscv.c (riscv_parse_check_conflicts): Prohibit
combination of RV64 and 'Zcf'.

gas/ChangeLog:

* testsuite/gas/riscv/march-fail-rv64i_zcf.d: New test.
* testsuite/gas/riscv/march-fail-rv64i_zcf.l: Likewise.

bfd/elfxx-riscv.c
gas/testsuite/gas/riscv/march-fail-rv64i_zcf.d [new file with mode: 0644]
gas/testsuite/gas/riscv/march-fail-rv64i_zcf.l [new file with mode: 0644]

index ee96608358e82b1e7dbe43805ba1e23d9cac8593..eaf496649db167fcf1c0887119afcab2186a2f31 100644 (file)
@@ -1946,6 +1946,13 @@ riscv_parse_check_conflicts (riscv_parse_subset_t *rps)
       rps->error_handler (_("rv%d does not support the `q' extension"), xlen);
       no_conflict = false;
     }
+  if (riscv_lookup_subset (rps->subset_list, "zcf", &subset)
+      && xlen > 32)
+    {
+      rps->error_handler
+       (_("rv%d does not support the `zcf' extension"), xlen);
+      no_conflict = false;
+    }
   if (riscv_lookup_subset (rps->subset_list, "zfinx", &subset)
       && riscv_lookup_subset (rps->subset_list, "f", &subset))
     {
diff --git a/gas/testsuite/gas/riscv/march-fail-rv64i_zcf.d b/gas/testsuite/gas/riscv/march-fail-rv64i_zcf.d
new file mode 100644 (file)
index 0000000..1b70a9e
--- /dev/null
@@ -0,0 +1,3 @@
+#as: -march=rv64i_zcf
+#source: empty.s
+#error_output: march-fail-rv64i_zcf.l
diff --git a/gas/testsuite/gas/riscv/march-fail-rv64i_zcf.l b/gas/testsuite/gas/riscv/march-fail-rv64i_zcf.l
new file mode 100644 (file)
index 0000000..b9e07c6
--- /dev/null
@@ -0,0 +1,2 @@
+.*Assembler messages:
+.*Error: .*rv64 does not support the `zcf' extension