]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
EDAC/mce_amd: Do not load edac_mce_amd module on guests
authorSmita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Mon, 28 Jun 2021 17:27:40 +0000 (12:27 -0500)
committerBorislav Petkov <bp@suse.de>
Mon, 9 Aug 2021 10:35:43 +0000 (12:35 +0200)
Hypervisors likely do not expose the SMCA feature to the guest and
loading this module leads to false warnings. This module should not be
loaded in guests to begin with, but people tend to do so, especially
when testing kernels in VMs. And then they complain about those false
warnings.

Do the practical thing and do not load this module when running as a
guest to avoid all that complaining.

 [ bp: Rewrite commit message. ]

Suggested-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Yazen Ghannam <yazen.ghannam@amd.com>
Tested-by: Kim Phillips <kim.phillips@amd.com>
Link: https://lkml.kernel.org/r/20210628172740.245689-1-Smita.KoralahalliChannabasappa@amd.com
drivers/edac/mce_amd.c

index 27d56920b4690ff578675bec58193bc7e3e25a84..67dbf4c3127163f96a3c0086e43696e3077b69fd 100644 (file)
@@ -1246,6 +1246,9 @@ static int __init mce_amd_init(void)
            c->x86_vendor != X86_VENDOR_HYGON)
                return -ENODEV;
 
+       if (cpu_feature_enabled(X86_FEATURE_HYPERVISOR))
+               return -ENODEV;
+
        if (boot_cpu_has(X86_FEATURE_SMCA)) {
                xec_mask = 0x3f;
                goto out;