]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-imap-storage: Don't sort uninitialized array on invalid header list.
authorTimo Sirainen <timo.sirainen@dovecot.fi>
Wed, 18 May 2016 18:41:49 +0000 (21:41 +0300)
committerTimo Sirainen <timo.sirainen@dovecot.fi>
Wed, 18 May 2016 18:41:49 +0000 (21:41 +0300)
src/lib-imap-storage/imap-msgpart.c

index aa9579039ea63e75d1dbffc22f6056c9bd13593e..aa1698231ce9063c143456bdb9cf0d5d110f9e00 100644 (file)
@@ -166,13 +166,12 @@ imap_msgpart_get_header_fields(pool_t pool, const char *header_list,
                        value = p_strdup(pool, t_str_ucase(value));
                        array_append(fields, &value, 1);
                }
+               /* istream-header-filter requires headers to be sorted */
+               array_sort(fields, i_strcasecmp_p);
        } else {
                result = -1;
        }
 
-       /* istream-header-filter requires headers to be sorted */
-       array_sort(fields, i_strcasecmp_p);
-
        imap_parser_unref(&parser);
        i_stream_unref(&input);
        return result;