]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
i2c: riic: Introduce a separate variable for IRQ
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Mon, 13 Jan 2025 12:26:34 +0000 (12:26 +0000)
committerWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 14 Jan 2025 12:01:21 +0000 (13:01 +0100)
Refactor the IRQ handling in riic_i2c_probe by introducing a local variable
`irq` to store IRQ numbers instead of assigning them to `ret`. This change
improves code readability and clarity.

Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
drivers/i2c/busses/i2c-riic.c

index 9264adc97ca9dfea75436122c2e3d55cd0414024..9809ac095710b536a796ebb4440ba72cd3ea5a06 100644 (file)
@@ -464,11 +464,13 @@ static int riic_i2c_probe(struct platform_device *pdev)
                return ret;
 
        for (i = 0; i < ARRAY_SIZE(riic_irqs); i++) {
-               ret = platform_get_irq(pdev, riic_irqs[i].res_num);
-               if (ret < 0)
-                       return ret;
+               int irq;
+
+               irq = platform_get_irq(pdev, riic_irqs[i].res_num);
+               if (irq < 0)
+                       return irq;
 
-               ret = devm_request_irq(dev, ret, riic_irqs[i].isr,
+               ret = devm_request_irq(dev, irq, riic_irqs[i].isr,
                                       0, riic_irqs[i].name, riic);
                if (ret) {
                        dev_err(dev, "failed to request irq %s\n", riic_irqs[i].name);