]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
MINOR: backend: mark srv as nonnull in alloc_dst_address()
authorAmaury Denoyelle <adenoyelle@haproxy.com>
Thu, 3 Apr 2025 13:17:53 +0000 (15:17 +0200)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Thu, 3 Apr 2025 15:19:07 +0000 (17:19 +0200)
Server instance can be NULL on connect_server(), either when dispatch or
transparent proxy are active. However, in alloc_dst_address() access to
<srv> is safe thanks to SF_ASSIGNED stream flag. Add an ASSUME_NONNULL()
to reflect this state.

This should fix coverity report from github issue #2922.

src/backend.c

index 8a3399efa976d4134d26d4ce6cba03277456448c..e49a12d05876b55f62727a01b90224ba95f06c1f 100644 (file)
@@ -888,6 +888,8 @@ static int alloc_dst_address(struct sockaddr_storage **ss,
                if (!sockaddr_alloc(ss, NULL, 0))
                        return SRV_STATUS_INTERNAL;
 
+               ASSUME_NONNULL(srv); /* srv is guaranteed by SF_ASSIGNED */
+
                **ss = srv->addr;
                set_host_port(*ss, srv->svc_port);
                if (!is_addr(*ss)) {