]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
5.10-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Jun 2022 09:24:29 +0000 (11:24 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 13 Jun 2022 09:24:29 +0000 (11:24 +0200)
added patches:
pci-qcom-fix-pipe-clock-imbalance.patch

queue-5.10/pci-qcom-fix-pipe-clock-imbalance.patch [new file with mode: 0644]
queue-5.10/series

diff --git a/queue-5.10/pci-qcom-fix-pipe-clock-imbalance.patch b/queue-5.10/pci-qcom-fix-pipe-clock-imbalance.patch
new file mode 100644 (file)
index 0000000..fb274be
--- /dev/null
@@ -0,0 +1,44 @@
+From fdf6a2f533115ec5d4d9629178f8196331f1ac50 Mon Sep 17 00:00:00 2001
+From: Johan Hovold <johan+linaro@kernel.org>
+Date: Fri, 1 Apr 2022 15:33:51 +0200
+Subject: PCI: qcom: Fix pipe clock imbalance
+
+From: Johan Hovold <johan+linaro@kernel.org>
+
+commit fdf6a2f533115ec5d4d9629178f8196331f1ac50 upstream.
+
+Fix a clock imbalance introduced by ed8cc3b1fc84 ("PCI: qcom: Add support
+for SDM845 PCIe controller"), which enables the pipe clock both in init()
+and in post_init() but only disables in post_deinit().
+
+Note that the pipe clock was also never disabled in the init() error
+paths and that enabling the clock before powering up the PHY looks
+questionable.
+
+Link: https://lore.kernel.org/r/20220401133351.10113-1-johan+linaro@kernel.org
+Fixes: ed8cc3b1fc84 ("PCI: qcom: Add support for SDM845 PCIe controller")
+Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
+Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
+Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
+Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
+Cc: stable@vger.kernel.org      # 5.6
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+---
+ drivers/pci/controller/dwc/pcie-qcom.c |    6 ------
+ 1 file changed, 6 deletions(-)
+
+--- a/drivers/pci/controller/dwc/pcie-qcom.c
++++ b/drivers/pci/controller/dwc/pcie-qcom.c
+@@ -1192,12 +1192,6 @@ static int qcom_pcie_init_2_7_0(struct q
+               goto err_disable_clocks;
+       }
+-      ret = clk_prepare_enable(res->pipe_clk);
+-      if (ret) {
+-              dev_err(dev, "cannot prepare/enable pipe clock\n");
+-              goto err_disable_clocks;
+-      }
+-
+       /* configure PCIe to RC mode */
+       writel(DEVICE_TYPE_RC, pcie->parf + PCIE20_PARF_DEVICE_TYPE);
index 86292cd4db2f6251e309bcb79128f63f18790bbd..0ff5c4fcecb92a6ee81c062a3ae7b8fcfca8ccd5 100644 (file)
@@ -168,3 +168,4 @@ powerpc-mm-switch-obsolete-dssall-to-.long.patch
 interconnect-qcom-sc7180-drop-ip0-interconnects.patch
 interconnect-restore-sync-state-by-ignoring-ipa-virt-in-provider-count.patch
 md-raid0-ignore-raid0-layout-if-the-second-zone-has-only-one-device.patch
+pci-qcom-fix-pipe-clock-imbalance.patch