USB: ohci-sm501: fix error return code in ohci_hcd_sm501_drv_probe()

[ Upstream commit b919e077cccfbb77beb98809568b2fb0b4d113ec ]

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 7d9e6f5aebe8 ("usb: host: ohci-sm501: init genalloc for local memory")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20200506135625.106910-1-weiyongjun1@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/usb/host/ohci-sm501.c b/drivers/usb/host/ohci-sm501.c
index c158cda9e4b9bc509d8e7fdf63fc6846fe8e07b9..cff96524032700fcaa33a89a61d06eca309d9085 100644 (file)
--- a/drivers/usb/host/ohci-sm501.c
+++ b/drivers/usb/host/ohci-sm501.c
@@ -157,9 +157,10 @@ static int ohci_hcd_sm501_drv_probe(struct platform_device *pdev)
         * the call to usb_hcd_setup_local_mem() below does just that.
         */
 
-       if (usb_hcd_setup_local_mem(hcd, mem->start,
-                                   mem->start - mem->parent->start,
-                                   resource_size(mem)) < 0)
+       retval = usb_hcd_setup_local_mem(hcd, mem->start,
+                                        mem->start - mem->parent->start,
+                                        resource_size(mem));
+       if (retval < 0)
                goto err5;
        retval = usb_add_hcd(hcd, irq, IRQF_SHARED);
        if (retval)