]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ipv4: fib: Remove unnecessary encap_type check
authorYue Haibing <yuehaibing@huawei.com>
Wed, 25 Jun 2025 02:20:59 +0000 (10:20 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 27 Jun 2025 00:16:03 +0000 (17:16 -0700)
lwtunnel_build_state() has check validity of encap_type,
so no need to do this before call it.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20250625022059.3958215-1-yuehaibing@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/fib_semantics.c

index f7c9c6a9f53e4248d42f6afc44e01e4fd3137509..a2f04992f5795ee56fc3af95f943988c998c18ee 100644 (file)
@@ -625,11 +625,6 @@ int fib_nh_common_init(struct net *net, struct fib_nh_common *nhc,
        if (encap) {
                struct lwtunnel_state *lwtstate;
 
-               if (encap_type == LWTUNNEL_ENCAP_NONE) {
-                       NL_SET_ERR_MSG(extack, "LWT encap type not specified");
-                       err = -EINVAL;
-                       goto lwt_failure;
-               }
                err = lwtunnel_build_state(net, encap_type, encap,
                                           nhc->nhc_family, cfg, &lwtstate,
                                           extack);