]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: typec: tipd: Use read_power_status function in probe
authorHector Martin <marcan@marcan.st>
Sun, 14 Sep 2025 12:56:14 +0000 (12:56 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 14 Sep 2025 14:08:21 +0000 (16:08 +0200)
We need the initial power status to be able to reliably detect connector
changes once we introduce de-bouncing for CD321x next. read_power_status
takes care of this and also forwards the status to the trace subsystem
so let's use that instead of open-coding it inside probe.

Signed-off-by: Hector Martin <marcan@marcan.st>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Neal Gompa <neal@gompa.dev>
Signed-off-by: Sven Peter <sven@kernel.org>
Link: https://lore.kernel.org/r/20250914-apple-usb3-tipd-v1-9-4e99c8649024@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/tipd/core.c

index e16c6c07c72a3e285f1fc94db72bed8dc3217a1d..f546f4ae563af3d411ec6591fe9c3b122e4efaab 100644 (file)
@@ -1549,11 +1549,8 @@ static int tps6598x_probe(struct i2c_client *client)
                goto err_role_put;
 
        if (status & TPS_STATUS_PLUG_PRESENT) {
-               ret = tps6598x_read16(tps, TPS_REG_POWER_STATUS, &tps->pwr_status);
-               if (ret < 0) {
-                       dev_err(tps->dev, "failed to read power status: %d\n", ret);
+               if (!tps6598x_read_power_status(tps))
                        goto err_unregister_port;
-               }
                ret = tps6598x_connect(tps, status);
                if (ret)
                        dev_err(&client->dev, "failed to register partner\n");