]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ntfs: fix ignoring unreachable code warnings
authorHyunchul Lee <hyc.lee@gmail.com>
Fri, 13 Mar 2026 00:47:01 +0000 (09:47 +0900)
committerNamjae Jeon <linkinjeon@kernel.org>
Mon, 16 Mar 2026 11:27:52 +0000 (20:27 +0900)
Detected by Smatch.

inode.c:1796 load_attribute_list_mount() warn:
  ignoring unreachable code.

Signed-off-by: Hyunchul Lee <hyc.lee@gmail.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
fs/ntfs/inode.c

index 0c202a03360f9cc9573700d2e31ce971c184bd62..314741a4036988c577f36a30ea44858e5fab1c00 100644 (file)
@@ -1761,7 +1761,7 @@ static int load_attribute_list_mount(struct ntfs_volume *vol,
                /* The attribute list cannot be sparse. */
                if (lcn < 0) {
                        ntfs_error(sb, "ntfs_rl_vcn_to_lcn() failed. Cannot read attribute list.");
-                       goto err_out;
+                       return -EIO;
                }
 
                rl_byte_off = ntfs_cluster_to_bytes(vol, lcn);
@@ -1774,7 +1774,7 @@ static int load_attribute_list_mount(struct ntfs_volume *vol,
                                   round_up(rl_byte_len, SECTOR_SIZE));
                if (err) {
                        ntfs_error(sb, "Cannot read attribute list.");
-                       goto err_out;
+                       return -EIO;
                }
 
                if (al + rl_byte_len >= al_end) {
@@ -1792,11 +1792,6 @@ initialize:
        }
 done:
        return err;
-       /* Real overflow! */
-       ntfs_error(sb, "Attribute list buffer overflow. Read attribute list is truncated.");
-err_out:
-       err = -EIO;
-       goto done;
 }
 
 /*