]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
pc-bios: s390x: Use ebcdic2ascii table
authorJanosch Frank <frankja@linux.ibm.com>
Wed, 24 Jun 2020 07:52:23 +0000 (03:52 -0400)
committerThomas Huth <thuth@redhat.com>
Thu, 2 Jul 2020 08:00:42 +0000 (10:00 +0200)
Why should we do conversion of a ebcdic value if we have a handy table
where we could look up the ascii value instead?

Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20200624075226.92728-10-frankja@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
pc-bios/s390-ccw/bootmap.c

index d13b7cbd1597bf2e531efcf8f54e70fcdbe387e9..97205674e59aebb23885349000aed07e1b5cc5e0 100644 (file)
@@ -328,9 +328,7 @@ static void print_eckd_ldl_msg(ECKD_IPL_mode_t mode)
         msg[0] = '2';
         break;
     default:
-        msg[0] = vlbl->LDL_version;
-        msg[0] &= 0x0f; /* convert EBCDIC   */
-        msg[0] |= 0x30; /* to ASCII (digit) */
+        msg[0] = ebc2asc[vlbl->LDL_version];
         msg[1] = '?';
         break;
     }