]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
x86/platform/iosf_mbi: Convert PCIBIOS_* return codes to errnos
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Mon, 27 May 2024 12:55:38 +0000 (15:55 +0300)
committerBorislav Petkov (AMD) <bp@alien8.de>
Mon, 24 Jun 2024 17:28:18 +0000 (19:28 +0200)
iosf_mbi_pci_{read,write}_mdr() use pci_{read,write}_config_dword()
that return PCIBIOS_* codes but functions also return -ENODEV which are
not compatible error codes. As neither of the functions are related to
PCI read/write functions, they should return normal errnos.

Convert PCIBIOS_* returns code using pcibios_err_to_errno() into normal
errno before returning it.

Fixes: 46184415368a ("arch: x86: New MailBox support driver for Intel SOC's")
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20240527125538.13620-4-ilpo.jarvinen@linux.intel.com
arch/x86/platform/intel/iosf_mbi.c

index fdd49d70b43738be371da7efb5476339ca315ef7..c81cea208c2c4392d79c4d2d42153ee7fec32811 100644 (file)
@@ -62,7 +62,7 @@ static int iosf_mbi_pci_read_mdr(u32 mcrx, u32 mcr, u32 *mdr)
 
 fail_read:
        dev_err(&mbi_pdev->dev, "PCI config access failed with %d\n", result);
-       return result;
+       return pcibios_err_to_errno(result);
 }
 
 static int iosf_mbi_pci_write_mdr(u32 mcrx, u32 mcr, u32 mdr)
@@ -91,7 +91,7 @@ static int iosf_mbi_pci_write_mdr(u32 mcrx, u32 mcr, u32 mdr)
 
 fail_write:
        dev_err(&mbi_pdev->dev, "PCI config access failed with %d\n", result);
-       return result;
+       return pcibios_err_to_errno(result);
 }
 
 int iosf_mbi_read(u8 port, u8 opcode, u32 offset, u32 *mdr)