]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
c: Fix ICE for redeclaration of structs with different alignment [PR114727]
authorMartin Uecker <uecker@tugraz.at>
Sat, 29 Jun 2024 13:53:43 +0000 (15:53 +0200)
committerMartin Uecker <uecker@gcc.gnu.org>
Tue, 9 Jul 2024 19:05:46 +0000 (21:05 +0200)
For redeclarations of struct in C23, if one has an alignment attribute
that makes the alignment different, we later get an ICE in verify_types.
This patches disallows such redeclarations by declaring such types to
be different.

PR c/114727

gcc/c/
* c-typeck.cc (tagged_types_tu_compatible): Add test.

gcc/testsuite/
* gcc.dg/pr114727.c: New test.

gcc/c/c-typeck.cc
gcc/testsuite/gcc.dg/pr114727.c [new file with mode: 0644]

index e486ac04f9cf774307979942889dce4379454d64..455dc374b481c84f4cbab5d975b882b763757280 100644 (file)
@@ -1603,6 +1603,9 @@ tagged_types_tu_compatible_p (const_tree t1, const_tree t2,
          != TYPE_REVERSE_STORAGE_ORDER (t2)))
     return false;
 
+  if (TYPE_USER_ALIGN (t1) != TYPE_USER_ALIGN (t2))
+    data->different_types_p = true;
+
   /* For types already being looked at in some active
      invocation of this function, assume compatibility.
      The cache is built as a linked list on the stack
diff --git a/gcc/testsuite/gcc.dg/pr114727.c b/gcc/testsuite/gcc.dg/pr114727.c
new file mode 100644 (file)
index 0000000..1294959
--- /dev/null
@@ -0,0 +1,6 @@
+/* { dg-do compile }
+ * { dg-options "-std=c23 -g" } */
+
+#define Y [[gnu::aligned(128)]]
+extern struct Y foo { int x; } x;
+struct foo { int x; };         /* { dg-error "redefinition" } */