]> git.ipfire.org Git - thirdparty/hostap.git/commitdiff
HS2.0: Skip check for roaming_consortium for NAI realm query
authorPurushottam Kushwaha <pkushwah@codeaurora.org>
Thu, 14 Nov 2019 09:15:10 +0000 (14:45 +0530)
committerJouni Malinen <j@w1.fi>
Sun, 17 Nov 2019 19:04:38 +0000 (21:04 +0200)
Previously ANQP fetch considered NAI realm query only when cred block
did not specify roaming_consortium to optimize ANQP operations (NAI
realm list can have a very long value). In certain cases, both NAI realm
and roaming_consortium are configured in credential block and this
resulted in ANQP fetch for NAI realm not being initiated. That could
result in not being able to select the highest priority available
credential/network.

Remove roaming_consortium check for NAI realm query inclusion in ANQP
request so that we will request NAI realm information whenever it can
result in matching additional networks. This makes the ANQP queries more
costly in some cases, but the additional information is needed for
correct behavior in network selection.

Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
wpa_supplicant/interworking.c

index d8e9c95a739d0af9070e3965aac65fb9457662f7..49b9907b079cf1f33ce76af7edb1bd86e0a78af9 100644 (file)
@@ -176,7 +176,7 @@ static int cred_with_nai_realm(struct wpa_supplicant *wpa_s)
                        continue;
                if (!cred->eap_method)
                        return 1;
-               if (cred->realm && cred->roaming_consortium_len == 0)
+               if (cred->realm)
                        return 1;
        }
        return 0;