is_nocall_function anticipates only being called for a function or a
method. However, PR gdb/29871 points out a situation where an unusual
expression -- but one that parses to a valid, if extremely weird,
function call -- breaks this assumption.
This patch changes is_nocall_function to remove this assert and
instead simply return 'false' in this case.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29871
bool
is_nocall_function (const struct type *type)
{
- gdb_assert (type->code () == TYPE_CODE_FUNC
- || type->code () == TYPE_CODE_METHOD);
+ if (type->code () != TYPE_CODE_FUNC && type->code () != TYPE_CODE_METHOD)
+ return false;
return TYPE_CALLING_CONVENTION (type) == DW_CC_nocall;
}
to call by the debugger.
This usually indicates that the function does not follow the target's
- standard calling convention.
-
- The TYPE argument must be of code TYPE_CODE_FUNC or TYPE_CODE_METHOD. */
+ standard calling convention. */
extern bool is_nocall_function (const struct type *type);
# Regression test for "&&".
gdb_test "print null_t_struct && null_t_struct->v_int_member == 0" \
" = 0"
+
+# Regression test for unusual function-call parse that caused a crash.
+gdb_test "print v_short++(97)" \
+ "cast the call to its declared return type"