xfs_io: fix null pointer deref when complaining about scrub command

Don't increment optind until we've validated that argv[optind] is a
valid scrub/repair subcommand and do not need to complain about
argv[optind].

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

diff --git a/io/scrub.c b/io/scrub.c
index cd2699741b0a8d4040f0b87deaac58d9e6159700..75a8ff158b9ef5f1c795420a7ec08d1de977649b 100644 (file)
--- a/io/scrub.c
+++ b/io/scrub.c
@@ -164,12 +164,11 @@ parse_args(
                        break;
                }
        }
-       optind++;
-
        if (type < 0) {
                printf(_("Unknown type '%s'.\n"), argv[optind]);
                return command_usage(cmdinfo);
        }
+       optind++;
 
        switch (d->type) {
        case ST_INODE: