]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wifi: rsi: Do not set MMC_PM_KEEP_POWER in shutdown
authorMarek Vasut <marex@denx.de>
Sat, 27 May 2023 22:28:59 +0000 (00:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jul 2023 06:37:09 +0000 (08:37 +0200)
[ Upstream commit e74f562328b03fbe9cf438f958464dff3a644dfc ]

It makes no sense to set MMC_PM_KEEP_POWER in shutdown. The flag
indicates to the MMC subsystem to keep the slot powered on during
suspend, but in shutdown the slot should actually be powered off.
Drop this call.

Fixes: 063848c3e155 ("rsi: sdio: Add WOWLAN support for S5 shutdown state")
Signed-off-by: Marek Vasut <marex@denx.de>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20230527222859.273768-1-marex@denx.de
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/rsi/rsi_91x_sdio.c

index 4fe837090cdaefb942966555d3a11d89a04a4ed0..22b0567ad826120afbbe0d6f02bf8f036a037f2c 100644 (file)
@@ -1479,9 +1479,6 @@ static void rsi_shutdown(struct device *dev)
        if (sdev->write_fail)
                rsi_dbg(INFO_ZONE, "###### Device is not ready #######\n");
 
-       if (rsi_set_sdio_pm_caps(adapter))
-               rsi_dbg(INFO_ZONE, "Setting power management caps failed\n");
-
        rsi_dbg(INFO_ZONE, "***** RSI module shut down *****\n");
 }