Cherry-picked trunk r11900: Bug 3433: Segfault closing SNMP

diff --git a/src/snmp_core.cc b/src/snmp_core.cc
index fd36968779c5b5ce7ad9658c44757635f85a0de2..e5579529ac61a28559c0a33d75a68de781a18662 100644 (file)
--- a/src/snmp_core.cc
+++ b/src/snmp_core.cc
@@ -358,13 +358,13 @@ snmpPortOpened(const Comm::ConnectionPointer &conn, int errNo)
 void
 snmpConnectionClose(void)
 {
-    if (!Comm::IsConnOpen(snmpIncomingConn)) {
+    if (Comm::IsConnOpen(snmpIncomingConn)) {
         debugs(49, DBG_IMPORTANT, "Closing SNMP receiving port " << snmpIncomingConn->local);
         snmpIncomingConn->close();
     }
     snmpIncomingConn = NULL;
 
-    if (!Comm::IsConnOpen(snmpOutgoingConn) && snmpIncomingConn != snmpOutgoingConn) {
+    if (Comm::IsConnOpen(snmpOutgoingConn) && snmpIncomingConn != snmpOutgoingConn) {
         // Perform OUT port closure so as not to step on IN port when sharing a conn.
         debugs(49, DBG_IMPORTANT, "Closing SNMP sending port " << snmpOutgoingConn->local);
         snmpOutgoingConn->close();