]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
bareudp: Use pcpu stats to update rx_dropped counter.
authorGuillaume Nault <gnault@redhat.com>
Fri, 18 Oct 2024 13:35:28 +0000 (15:35 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 28 Oct 2024 11:16:32 +0000 (11:16 +0000)
Use the core_stats rx_dropped counter to avoid the cost of atomic
increments.

Signed-off-by: Guillaume Nault <gnault@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/bareudp.c

index fa2dd76ba3d9e2b8b04d213faf5a0ea47b398750..a2abfade82dd1cf3d849aba1ba9083a30993e132 100644 (file)
@@ -84,7 +84,7 @@ static int bareudp_udp_encap_recv(struct sock *sk, struct sk_buff *skb)
 
                if (skb_copy_bits(skb, BAREUDP_BASE_HLEN, &ipversion,
                                  sizeof(ipversion))) {
-                       DEV_STATS_INC(bareudp->dev, rx_dropped);
+                       dev_core_stats_rx_dropped_inc(bareudp->dev);
                        goto drop;
                }
                ipversion >>= 4;
@@ -94,7 +94,7 @@ static int bareudp_udp_encap_recv(struct sock *sk, struct sk_buff *skb)
                } else if (ipversion == 6 && bareudp->multi_proto_mode) {
                        proto = htons(ETH_P_IPV6);
                } else {
-                       DEV_STATS_INC(bareudp->dev, rx_dropped);
+                       dev_core_stats_rx_dropped_inc(bareudp->dev);
                        goto drop;
                }
        } else if (bareudp->ethertype == htons(ETH_P_MPLS_UC)) {
@@ -108,7 +108,7 @@ static int bareudp_udp_encap_recv(struct sock *sk, struct sk_buff *skb)
                                   ipv4_is_multicast(tunnel_hdr->daddr)) {
                                proto = htons(ETH_P_MPLS_MC);
                        } else {
-                               DEV_STATS_INC(bareudp->dev, rx_dropped);
+                               dev_core_stats_rx_dropped_inc(bareudp->dev);
                                goto drop;
                        }
                } else {
@@ -124,7 +124,7 @@ static int bareudp_udp_encap_recv(struct sock *sk, struct sk_buff *skb)
                                   (addr_type & IPV6_ADDR_MULTICAST)) {
                                proto = htons(ETH_P_MPLS_MC);
                        } else {
-                               DEV_STATS_INC(bareudp->dev, rx_dropped);
+                               dev_core_stats_rx_dropped_inc(bareudp->dev);
                                goto drop;
                        }
                }
@@ -136,7 +136,7 @@ static int bareudp_udp_encap_recv(struct sock *sk, struct sk_buff *skb)
                                 proto,
                                 !net_eq(bareudp->net,
                                 dev_net(bareudp->dev)))) {
-               DEV_STATS_INC(bareudp->dev, rx_dropped);
+               dev_core_stats_rx_dropped_inc(bareudp->dev);
                goto drop;
        }
 
@@ -144,7 +144,7 @@ static int bareudp_udp_encap_recv(struct sock *sk, struct sk_buff *skb)
 
        tun_dst = udp_tun_rx_dst(skb, family, key, 0, 0);
        if (!tun_dst) {
-               DEV_STATS_INC(bareudp->dev, rx_dropped);
+               dev_core_stats_rx_dropped_inc(bareudp->dev);
                goto drop;
        }
        skb_dst_set(skb, &tun_dst->dst);