]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
gdb sim testing, set gdb_protocol to "sim"
authorPedro Alves <pedro@palves.net>
Thu, 9 May 2024 12:01:53 +0000 (13:01 +0100)
committerPedro Alves <pedro@palves.net>
Fri, 10 May 2024 10:48:57 +0000 (11:48 +0100)
Bernd reported that when testing with riscv-unknown-elf target using
the simulator, before commit c7a2ee649115 ("gdb_is_target_native ->
gdb_protocol_is_native"), he had:

 PASS: gdb.base/load-command.exp: probe for target native
 PASS: gdb.base/load-command.exp: check initial value of the_variable
 PASS: gdb.base/load-command.exp: manually change the_variable
 PASS: gdb.base/load-command.exp: check manually changed value of the_variable
 PASS: gdb.base/load-command.exp: reload: re-load binary
 PASS: gdb.base/load-command.exp: reload: check initial value of the_variable

and now:

 UNSUPPORTED: gdb.base/load-command.exp: the native target does not support the load command

The problem is that the sim board/config isn't setting gdb_protocol
anywhere, so gdb_protocol_is_native returns true.

This commit fixes it by making gdb/testsuite/config/sim.exp set
gdb_protocol to "sim".

Reported-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Tested-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
Change-Id: I48a7afed004a3517b90220674fe5bc856fe7d09a

gdb/testsuite/config/sim.exp

index 81736d25814498c91470ef7f5ad7aa2375be8b41..da2780e1d470c0df46f17b07954cf1dadd50197a 100644 (file)
 # You should have received a copy of the GNU General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+# If we left this empty, the core of the testsuite would think we were
+# connecting to the native target.
+set_board_info gdb_protocol "sim"
+
 #
 # gdb_target_sim
 # Set gdb to target the simulator