]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: stmmac: mdio: remove redundant clock rate tests
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thu, 4 Sep 2025 12:11:46 +0000 (13:11 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 9 Sep 2025 01:12:03 +0000 (18:12 -0700)
The pattern:

... if (v < A)
...
else if (v >= A && v < B)
...

can be simplified to:

... if (v < A)
...
else if (v < B)
...

which makes the string of ifelse more readable.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Mohd Ayaan Anwar <quic_mohdayaa@quicinc.com>
Link: https://patch.msgid.link/E1uu8oc-00000001vpN-0S1A@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c

index e5ca206ee46fdea4cd8673140ce428fbc4e58376..f408737f6fc73e3cd2d3c72361078cfa6b3442f0 100644 (file)
@@ -502,19 +502,19 @@ static u32 stmmac_clk_csr_set(struct stmmac_priv *priv)
         */
        if (clk_rate < CSR_F_35M)
                value = STMMAC_CSR_20_35M;
-       else if ((clk_rate >= CSR_F_35M) && (clk_rate < CSR_F_60M))
+       else if (clk_rate < CSR_F_60M)
                value = STMMAC_CSR_35_60M;
-       else if ((clk_rate >= CSR_F_60M) && (clk_rate < CSR_F_100M))
+       else if (clk_rate < CSR_F_100M)
                value = STMMAC_CSR_60_100M;
-       else if ((clk_rate >= CSR_F_100M) && (clk_rate < CSR_F_150M))
+       else if (clk_rate < CSR_F_150M)
                value = STMMAC_CSR_100_150M;
-       else if ((clk_rate >= CSR_F_150M) && (clk_rate < CSR_F_250M))
+       else if (clk_rate < CSR_F_250M)
                value = STMMAC_CSR_150_250M;
-       else if ((clk_rate >= CSR_F_250M) && (clk_rate <= CSR_F_300M))
+       else if (clk_rate <= CSR_F_300M)
                value = STMMAC_CSR_250_300M;
-       else if ((clk_rate >= CSR_F_300M) && (clk_rate < CSR_F_500M))
+       else if (clk_rate < CSR_F_500M)
                value = STMMAC_CSR_300_500M;
-       else if ((clk_rate >= CSR_F_500M) && (clk_rate < CSR_F_800M))
+       else if (clk_rate < CSR_F_800M)
                value = STMMAC_CSR_500_800M;
 
        if (priv->plat->flags & STMMAC_FLAG_HAS_SUN8I) {