]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
irqchip/renesas-rzg2l: Use devm_reset_control_get_exclusive_deasserted()
authorFabrizio Castro <fabrizio.castro.jz@renesas.com>
Wed, 12 Feb 2025 18:20:30 +0000 (18:20 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 18 Feb 2025 08:03:52 +0000 (09:03 +0100)
Use devm_reset_control_get_exclusive_deasserted() to simplify
rzg2l_irqc_common_init().

Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://lore.kernel.org/all/20250212182034.366167-3-fabrizio.castro.jz@renesas.com
drivers/irqchip/irq-renesas-rzg2l.c

index a7c3a3cc6b9f76f67d96879c11627ef38a8e0153..a29c4046613725220eef3dc9b1f9e0af0987f9ff 100644 (file)
@@ -562,14 +562,10 @@ static int rzg2l_irqc_common_init(struct device_node *node, struct device_node *
                return ret;
        }
 
-       resetn = devm_reset_control_get_exclusive(dev, NULL);
-       if (IS_ERR(resetn))
+       resetn = devm_reset_control_get_exclusive_deasserted(dev, NULL);
+       if (IS_ERR(resetn)) {
+               dev_err(dev, "failed to acquire deasserted reset: %d\n", ret);
                return PTR_ERR(resetn);
-
-       ret = reset_control_deassert(resetn);
-       if (ret) {
-               dev_err(dev, "failed to deassert resetn pin, %d\n", ret);
-               return ret;
        }
 
        pm_runtime_enable(dev);
@@ -609,7 +605,6 @@ pm_put:
        pm_runtime_put(dev);
 pm_disable:
        pm_runtime_disable(dev);
-       reset_control_assert(resetn);
        return ret;
 }