firmware: avoid pointless reference count bump

The creds are allocated via prepare_kernel_cred() which has already
taken a reference.

Link: https://lore.kernel.org/r/20241125-work-cred-v2-7-68b9d38bb5b2@kernel.org
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Christian Brauner <brauner@kernel.org>

diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
index a97fa36ee4bd6be09d43ed48719ba40b4d8d2591..cb0912ea3e627e92f2009257314531981a279a92 100644 (file)
--- a/drivers/base/firmware_loader/main.c
+++ b/drivers/base/firmware_loader/main.c
@@ -911,7 +911,7 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
                ret = -ENOMEM;
                goto out;
        }
-       old_cred = override_creds(get_new_cred(kern_cred));
+       old_cred = override_creds(kern_cred);
 
        ret = fw_get_filesystem_firmware(device, fw->priv, "", NULL);
 
@@ -943,7 +943,7 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
        } else
                ret = assign_fw(fw, device);
 
-       put_cred(revert_creds(old_cred));
+       revert_creds(old_cred);
        put_cred(kern_cred);
 
 out: