]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915/pmu: Remove pointless synchronize_rcu() call
authorLucas De Marchi <lucas.demarchi@intel.com>
Mon, 4 Nov 2024 21:35:12 +0000 (13:35 -0800)
committerLucas De Marchi <lucas.demarchi@intel.com>
Tue, 5 Nov 2024 19:24:33 +0000 (11:24 -0800)
This is already done inside perf_pmu_unregister() - no need to do it
before.

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241104213512.2314930-5-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/i915/i915_pmu.c

index bd476297ed0a13ba6b6dc76cdaec5d182c7aebb8..e55db036be1bba49f833e23ed68ec405b7734f2a 100644 (file)
@@ -1335,13 +1335,8 @@ void i915_pmu_unregister(struct drm_i915_private *i915)
        if (!pmu->registered)
                return;
 
-       /*
-        * "Disconnect" the PMU callbacks - since all are atomic synchronize_rcu
-        * ensures all currently executing ones will have exited before we
-        * proceed with unregistration.
-        */
+       /* Disconnect the PMU callbacks */
        pmu->registered = false;
-       synchronize_rcu();
 
        hrtimer_cancel(&pmu->timer);