PR31941 objcopy --globalize-symbol

I think FILE symbols are special, and I can't see why anyone would
want them to be made global.  The fact that no one has reported this
bug since commit 7b4a0685e80a in 2005 supports that claim.

	PR 31941
	* objcopy.c (filter_symbols): Don't allow BSF_FILE symbols to
	be made global.

diff --git a/binutils/objcopy.c b/binutils/objcopy.c
index f54ae734198a437c00c85dd31bb87abfd9699d5c..5fb33b5509a310804a7bd74237dd04921144a3ed 100644 (file)
--- a/binutils/objcopy.c
+++ b/binutils/objcopy.c
@@ -1743,6 +1743,7 @@ filter_symbols (bfd *abfd, bfd *obfd, asymbol **osyms,
 
          else if (!undefined
                   && (flags & BSF_LOCAL)
+                  && !(flags & BSF_FILE)
                   && is_specified_symbol (name, globalize_specific_htab))
            {
              flags &= ~BSF_LOCAL;