]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cpufreq/amd-pstate: Call cppc_set_epp_perf in the reenable function
authorDhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
Wed, 23 Oct 2024 10:21:10 +0000 (10:21 +0000)
committerMario Limonciello <mario.limonciello@amd.com>
Mon, 28 Oct 2024 19:54:36 +0000 (14:54 -0500)
The EPP value being set in perf_ctrls.energy_perf is not being propagated
to the shared memory, fix that.

Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Perry Yuan <perry.yuan@amd.com>
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Link: https://lore.kernel.org/r/20241023102108.5980-4-Dhananjay.Ugwekar@amd.com
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
drivers/cpufreq/amd-pstate.c

index 576251e61ce0722b9e816af0280b6880cf3db8d3..bbeddce908236abd50281c37ef0ce8d7671ed160 100644 (file)
@@ -1616,8 +1616,9 @@ static void amd_pstate_epp_reenable(struct amd_cpudata *cpudata)
                wrmsrl_on_cpu(cpudata->cpu, MSR_AMD_CPPC_REQ, value);
        } else {
                perf_ctrls.max_perf = max_perf;
-               perf_ctrls.energy_perf = AMD_CPPC_ENERGY_PERF_PREF(cpudata->epp_cached);
                cppc_set_perf(cpudata->cpu, &perf_ctrls);
+               perf_ctrls.energy_perf = AMD_CPPC_ENERGY_PERF_PREF(cpudata->epp_cached);
+               cppc_set_epp_perf(cpudata->cpu, &perf_ctrls, 1);
        }
 }
 
@@ -1658,8 +1659,9 @@ static void amd_pstate_epp_offline(struct cpufreq_policy *policy)
        } else {
                perf_ctrls.desired_perf = 0;
                perf_ctrls.max_perf = min_perf;
-               perf_ctrls.energy_perf = AMD_CPPC_ENERGY_PERF_PREF(HWP_EPP_BALANCE_POWERSAVE);
                cppc_set_perf(cpudata->cpu, &perf_ctrls);
+               perf_ctrls.energy_perf = AMD_CPPC_ENERGY_PERF_PREF(HWP_EPP_BALANCE_POWERSAVE);
+               cppc_set_epp_perf(cpudata->cpu, &perf_ctrls, 1);
        }
        mutex_unlock(&amd_pstate_limits_lock);
 }