]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: axienet: start napi before enabling Rx/Tx
authorAndy Chiu <andy.chiu@sifive.com>
Fri, 26 Jul 2024 07:06:50 +0000 (15:06 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 29 Jul 2024 10:35:37 +0000 (11:35 +0100)
softirq may get lost if an Rx interrupt comes before we call
napi_enable. Move napi_enable in front of axienet_setoptions(), which
turns on the device, to address the issue.

Link: https://lists.gnu.org/archive/html/qemu-devel/2024-07/msg06160.html
Fixes: cc37610caaf8 ("net: axienet: implement NAPI and GRO receive")
Signed-off-by: Andy Chiu <andy.chiu@sifive.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/xilinx/xilinx_axienet_main.c

index e342f387c3dd643cb2cb173524484cf2004547ae..02fdf66e07faa33887f361c699ded2360b9cae5d 100644 (file)
@@ -2219,9 +2219,9 @@ static void axienet_dma_err_handler(struct work_struct *work)
                           ~(XAE_OPTION_TXEN | XAE_OPTION_RXEN));
        axienet_set_mac_address(ndev, NULL);
        axienet_set_multicast_list(ndev);
-       axienet_setoptions(ndev, lp->options);
        napi_enable(&lp->napi_rx);
        napi_enable(&lp->napi_tx);
+       axienet_setoptions(ndev, lp->options);
 }
 
 /**