Use scoped_free_pendings in coff_symtab_read

PR gdb/18624 concerns an assertion failure that occurs when setting a
breakpoint in a Go program on Windows.

What happens here is that coff_symtab_read uses buildsym but does not
instantiate scoped_free_pendings.  So, the struct pending objects are
never released.  Later, dwarf2read.c calls buildsym_init, which
asserts.

This patch fixes the problem by instantiating scoped_free_pendings in
coff_symtab_read.

Tested using the test executable from the PR.  I don't know how to
test this more fully.

2018-07-17  Tom Tromey  <tom@tromey.com>

	PR gdb/18624:
	* coffread.c (coff_symtab_read): Use scoped_free_pendings.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 7b77e873c0fbadca33153a93e8d469abad6110ae..7388c7d63fcd7c3c2761a1ad2ef9cd7653debad8 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-07-17  Tom Tromey  <tom@tromey.com>
+
+       PR gdb/18624:
+       * coffread.c (coff_symtab_read): Use scoped_free_pendings.
+
 2018-07-11  Pedro Alves  <palves@redhat.com>
 
        PR gdb/23377

diff --git a/gdb/coffread.c b/gdb/coffread.c
index 30583e1dda46fb6460ee54635b5de176d4aab33e..9e2edde19a889fec03522994e3f0c334f8618732 100644 (file)
--- a/gdb/coffread.c
+++ b/gdb/coffread.c
@@ -803,6 +803,9 @@ coff_symtab_read (minimal_symbol_reader &reader,
   CORE_ADDR tmpaddr;
   struct minimal_symbol *msym;
 
+  buildsym_init ();
+  scoped_free_pendings free_pending;
+
   /* Work around a stdio bug in SunOS4.1.1 (this makes me nervous....
      it's hard to know I've really worked around it.  The fix should
      be harmless, anyway).  The symptom of the bug is that the first