]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
sfc: Remove newline at the end of a netlink error message
authorGal Pressman <gal@nvidia.com>
Wed, 26 Feb 2025 09:39:02 +0000 (11:39 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 28 Feb 2025 02:11:37 +0000 (18:11 -0800)
Netlink error messages should not have a newline at the end of the
string.

Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Link: https://patch.msgid.link/20250226093904.6632-4-gal@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/sfc/mae.c
drivers/net/ethernet/sfc/tc.c

index 50f097487b140b951167aa069732c728026e15f5..6fd0c1e9a7d54a26b4afb32301f86decbd422f85 100644 (file)
@@ -755,7 +755,7 @@ int efx_mae_match_check_caps_lhs(struct efx_nic *efx,
        rc = efx_mae_match_check_cap_typ(supported_fields[MAE_FIELD_INGRESS_PORT],
                                         ingress_port_mask_type);
        if (rc) {
-               NL_SET_ERR_MSG_FMT_MOD(extack, "No support for %s mask in field %s\n",
+               NL_SET_ERR_MSG_FMT_MOD(extack, "No support for %s mask in field %s",
                                       mask_type_name(ingress_port_mask_type),
                                       "ingress_port");
                return rc;
index 0d93164988fc6501ad687f6098d9c218ac44df85..fa94aa3cd5fee098ba16b12489fa1b195544a0de 100644 (file)
@@ -1043,7 +1043,7 @@ static int efx_tc_flower_handle_lhs_actions(struct efx_nic *efx,
                                return -EOPNOTSUPP;
                        }
                        if (fa->ct.action) {
-                               NL_SET_ERR_MSG_FMT_MOD(extack, "Unhandled ct.action %u for LHS rule\n",
+                               NL_SET_ERR_MSG_FMT_MOD(extack, "Unhandled ct.action %u for LHS rule",
                                                       fa->ct.action);
                                return -EOPNOTSUPP;
                        }
@@ -1056,7 +1056,7 @@ static int efx_tc_flower_handle_lhs_actions(struct efx_nic *efx,
                        act->zone = ct_zone;
                        break;
                default:
-                       NL_SET_ERR_MSG_FMT_MOD(extack, "Unhandled action %u for LHS rule\n",
+                       NL_SET_ERR_MSG_FMT_MOD(extack, "Unhandled action %u for LHS rule",
                                               fa->id);
                        return -EOPNOTSUPP;
                }
@@ -1581,7 +1581,7 @@ static int efx_tc_flower_replace_foreign_lhs(struct efx_nic *efx,
 
        type = efx_tc_indr_netdev_type(net_dev);
        if (type == EFX_ENCAP_TYPE_NONE) {
-               NL_SET_ERR_MSG_MOD(extack, "Egress encap match on unsupported tunnel device\n");
+               NL_SET_ERR_MSG_MOD(extack, "Egress encap match on unsupported tunnel device");
                return -EOPNOTSUPP;
        }