]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
iio: hid-sensor-prox: Fix incorrect OFFSET calculation
authorZhang Lixu <lixu.zhang@intel.com>
Mon, 31 Mar 2025 05:50:22 +0000 (13:50 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 7 Apr 2025 18:32:50 +0000 (19:32 +0100)
The OFFSET calculation in the prox_read_raw() was incorrectly using the
unit exponent, which is intended for SCALE calculations.

Remove the incorrect OFFSET calculation and set it to a fixed value of 0.

Cc: stable@vger.kernel.org
Fixes: 39a3a0138f61 ("iio: hid-sensors: Added Proximity Sensor Driver")
Signed-off-by: Zhang Lixu <lixu.zhang@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Link: https://patch.msgid.link/20250331055022.1149736-4-lixu.zhang@intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/light/hid-sensor-prox.c

index 941508e58286c939d2e28cbe8c1c01967123d468..4c65b32d34ce41e4b2d73096f05add0bb9c765eb 100644 (file)
@@ -124,8 +124,7 @@ static int prox_read_raw(struct iio_dev *indio_dev,
                ret_type = prox_state->scale_precision[chan->scan_index];
                break;
        case IIO_CHAN_INFO_OFFSET:
-               *val = hid_sensor_convert_exponent(
-                       prox_state->prox_attr[chan->scan_index].unit_expo);
+               *val = 0;
                ret_type = IIO_VAL_INT;
                break;
        case IIO_CHAN_INFO_SAMP_FREQ: