]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
domain_conf: graphics: extract SDL formatting to separate function
authorPavel Hrdina <phrdina@redhat.com>
Thu, 6 Mar 2025 10:48:39 +0000 (11:48 +0100)
committerPavel Hrdina <phrdina@redhat.com>
Fri, 7 Mar 2025 13:01:27 +0000 (14:01 +0100)
virDomainGraphicsDefFormat function was way too long so split it into
separate functions for each graphics type.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/conf/domain_conf.c

index 6884a317d70eb5659f11cc55c76a0e4d0a27976e..697d5f18ba18f8cf51b7d382a6619a05749d1efa 100644 (file)
@@ -26492,6 +26492,21 @@ virDomainGraphicsDefFormatVNC(virBuffer *attrBuf,
     return 0;
 }
 
+static void
+virDomainGraphicsDefFormatSDL(virBuffer *attrBuf,
+                              virBuffer *childBuf,
+                              virDomainGraphicsDef *def)
+{
+    virBufferEscapeString(attrBuf, " display='%s'", def->data.sdl.display);
+
+    virBufferEscapeString(attrBuf, " xauth='%s'", def->data.sdl.xauth);
+
+    if (def->data.sdl.fullscreen)
+        virBufferAddLit(attrBuf, " fullscreen='yes'");
+
+    virDomainGraphicsDefFormatGL(childBuf, def->data.sdl.gl, NULL);
+}
+
 static int
 virDomainGraphicsDefFormat(virBuffer *buf,
                            virDomainGraphicsDef *def,
@@ -26518,15 +26533,7 @@ virDomainGraphicsDefFormat(virBuffer *buf,
         break;
 
     case VIR_DOMAIN_GRAPHICS_TYPE_SDL:
-        virBufferEscapeString(&attrBuf, " display='%s'",
-                              def->data.sdl.display);
-
-        virBufferEscapeString(&attrBuf, " xauth='%s'",
-                              def->data.sdl.xauth);
-        if (def->data.sdl.fullscreen)
-            virBufferAddLit(&attrBuf, " fullscreen='yes'");
-
-        virDomainGraphicsDefFormatGL(&childBuf, def->data.sdl.gl, NULL);
+        virDomainGraphicsDefFormatSDL(&attrBuf, &childBuf, def);
         break;
 
     case VIR_DOMAIN_GRAPHICS_TYPE_RDP: