]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/bochs: Pass bochs device to various functions
authorThomas Zimmermann <tzimmermann@suse.de>
Mon, 2 Sep 2024 10:53:42 +0000 (12:53 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 6 Sep 2024 12:41:35 +0000 (14:41 +0200)
Avoid upcasting from struct drm_device by passing the bochs device
directly to functions.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240902105546.792625-5-tzimmermann@suse.de
drivers/gpu/drm/tiny/bochs.c

index 5d09b4cb28ed0568e6bfc93af9149c1b121046f7..acb2652577d4ef6b1cc45e3bf2a17c3bf2d70c00 100644 (file)
@@ -204,9 +204,9 @@ static const struct drm_edid *bochs_hw_read_edid(struct drm_connector *connector
        return drm_edid_read_custom(connector, bochs_get_edid_block, bochs);
 }
 
-static int bochs_hw_init(struct drm_device *dev)
+static int bochs_hw_init(struct bochs_device *bochs)
 {
-       struct bochs_device *bochs = dev->dev_private;
+       struct drm_device *dev = bochs->dev;
        struct pci_dev *pdev = to_pci_dev(dev->dev);
        unsigned long addr, size, mem, ioaddr, iosize;
        u16 id;
@@ -481,9 +481,9 @@ static const struct drm_connector_funcs bochs_connector_connector_funcs = {
        .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
 };
 
-static void bochs_connector_init(struct drm_device *dev)
+static void bochs_connector_init(struct bochs_device *bochs)
 {
-       struct bochs_device *bochs = dev->dev_private;
+       struct drm_device *dev = bochs->dev;
        struct drm_connector *connector = &bochs->connector;
 
        drm_connector_init(dev, connector, &bochs_connector_connector_funcs,
@@ -516,7 +516,7 @@ static int bochs_kms_init(struct bochs_device *bochs)
 
        bochs->dev->mode_config.funcs = &bochs_mode_funcs;
 
-       bochs_connector_init(bochs->dev);
+       bochs_connector_init(bochs);
        drm_simple_display_pipe_init(bochs->dev,
                                     &bochs->pipe,
                                     &bochs_pipe_funcs,
@@ -544,7 +544,7 @@ static int bochs_load(struct drm_device *dev)
        dev->dev_private = bochs;
        bochs->dev = dev;
 
-       ret = bochs_hw_init(dev);
+       ret = bochs_hw_init(bochs);
        if (ret)
                return ret;