Appease clang-tidy

Signed-off-by: Miod Vallat <miod.vallat@powerdns.com>

diff --git a/modules/lmdbbackend/lmdbbackend.cc b/modules/lmdbbackend/lmdbbackend.cc
index dc0af2818b92b410d11ce625338160f9c53e8b7d..7da2de0b0e871c4909f87c4859c626891d25254a 100644 (file)
--- a/modules/lmdbbackend/lmdbbackend.cc
+++ b/modules/lmdbbackend/lmdbbackend.cc
@@ -1687,8 +1687,8 @@ bool LMDBBackend::deleteDomain(const ZoneName& domain)
     auto txn = d_tdomains->getROTransaction();
 
     DomainInfo di;
-    if (auto id = txn.get<0>(domain, di); id != 0) {
-      idvec.push_back(id);
+    if (auto domain_id = txn.get<0>(domain, di); domain_id != 0) {
+      idvec.push_back(domain_id);
     }
   }
   else {
@@ -2031,7 +2031,7 @@ bool LMDBBackend::getDomainInfo(const ZoneName& domain, DomainInfo& info, bool g
   return true;
 }
 
-int LMDBBackend::genChangeDomain(const ZoneName& domain, const std::function<void(DomainInfo&)>& func)
+bool LMDBBackend::genChangeDomain(const ZoneName& domain, const std::function<void(DomainInfo&)>& func)
 {
   auto txn = d_tdomains->getRWTransaction();
 
@@ -2049,7 +2049,7 @@ int LMDBBackend::genChangeDomain(const ZoneName& domain, const std::function<voi
 }
 
 // NOLINTNEXTLINE(readability-identifier-length)
-int LMDBBackend::genChangeDomain(domainid_t id, const std::function<void(DomainInfo&)>& func)
+bool LMDBBackend::genChangeDomain(domainid_t id, const std::function<void(DomainInfo&)>& func)
 {
   DomainInfo di;
 

diff --git a/modules/lmdbbackend/lmdbbackend.hh b/modules/lmdbbackend/lmdbbackend.hh
index e7db2b43d9ceabe76f4288639349b4d72c7a79e0..3665533a0a9e99871aacf498b3f59f489bf6f28a 100644 (file)
--- a/modules/lmdbbackend/lmdbbackend.hh
+++ b/modules/lmdbbackend/lmdbbackend.hh
@@ -333,8 +333,8 @@ private:
   void openAllTheDatabases();
   std::shared_ptr<RecordsRWTransaction> getRecordsRWTransaction(domainid_t id);
   std::shared_ptr<RecordsROTransaction> getRecordsROTransaction(domainid_t id, const std::shared_ptr<LMDBBackend::RecordsRWTransaction>& rwtxn = nullptr);
-  int genChangeDomain(const ZoneName& domain, const std::function<void(DomainInfo&)>& func);
-  int genChangeDomain(domainid_t id, const std::function<void(DomainInfo&)>& func);
+  bool genChangeDomain(const ZoneName& domain, const std::function<void(DomainInfo&)>& func);
+  bool genChangeDomain(domainid_t id, const std::function<void(DomainInfo&)>& func);
   static void deleteDomainRecords(RecordsRWTransaction& txn, const std::string& match);
 
   void getAllDomainsFiltered(vector<DomainInfo>* domains, const std::function<bool(DomainInfo&)>& allow);