]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Initialize value in bit_value_unop.
authorAldy Hernandez <aldyh@redhat.com>
Tue, 25 Jul 2023 16:25:30 +0000 (12:25 -0400)
committerAldy Hernandez <aldyh@redhat.com>
Wed, 26 Jul 2023 08:37:24 +0000 (10:37 +0200)
bit_value_binop initializes VAL regardless of the final mask.  It even
has a comment to that effect:

  /* Ensure that VAL is initialized (to any value).  */

However, bit_value_unop, which in theory shares the same API, does not.
This causes range-ops to choke on uninitialized VALs for some inputs to
ABS.

Instead of fixing the callers, it's cleaner to make bit_value_unop and
bit_value_binop consistent.

gcc/ChangeLog:

* tree-ssa-ccp.cc (bit_value_unop): Initialize val when appropriate.

gcc/tree-ssa-ccp.cc

index 73fb7c11c643f75431e1a3e5b49c05385f4bf2e8..15e65f1600846cd5a22d17e9141bcfab7591c0ed 100644 (file)
@@ -1359,7 +1359,10 @@ bit_value_unop (enum tree_code code, signop type_sgn, int type_precision,
     case ABS_EXPR:
     case ABSU_EXPR:
       if (wi::sext (rmask, rtype_precision) == -1)
-       *mask = -1;
+       {
+         *mask = -1;
+         *val = 0;
+       }
       else if (wi::neg_p (rmask))
        {
          /* Result is either rval or -rval.  */
@@ -1385,6 +1388,7 @@ bit_value_unop (enum tree_code code, signop type_sgn, int type_precision,
 
     default:
       *mask = -1;
+      *val = 0;
       break;
     }
 }