Bug 1470966 - "Status" column in Phabricator dashboard isn't very useful

diff --git a/extensions/MyDashboard/web/js/flags.js b/extensions/MyDashboard/web/js/flags.js
index b56559ae38b92ac47ce7826af8c121dd72ed2c9f..425e42e57a1807dd231ed306912f844dce3201c6 100644 (file)
--- a/extensions/MyDashboard/web/js/flags.js
+++ b/extensions/MyDashboard/web/js/flags.js
@@ -180,8 +180,6 @@ $(function () {
                 columns: [
                     { key: 'author_email', label: 'Requester', sortable: true,
                         formattter: phabAuthorFormatter, allowHTML: true },
-                    { key: 'id', label: 'Status', sortable: true,
-                        nodeFormatter: phabRowFormatter, allowHTML: true },
                     { key: 'bug_id', label: 'Bug', sortable: true,
                         formatter: bugLinkFormatter, allowHTML: true },
                     { key: 'updated', label: 'Updated', sortable: true,

diff --git a/extensions/PhabBugz/lib/Util.pm b/extensions/PhabBugz/lib/Util.pm
index c4c9c79929f500d3603711f0cc451a4db3963be9..214bc3fb7a6af71b9065037232df59929117675b 100644 (file)
--- a/extensions/PhabBugz/lib/Util.pm
+++ b/extensions/PhabBugz/lib/Util.pm
@@ -274,16 +274,7 @@ sub get_needs_review {
     ThrowCodeError('phabricator_api_error', { reason => 'Malformed Response' })
         unless exists $diffs->{result}{data};
 
-    # extract this reviewer's status from 'attachments'
-    my @result;
-    foreach my $diff (@{ $diffs->{result}{data} }) {
-        my $attachments = delete $diff->{attachments};
-        my $reviewers   = $attachments->{reviewers}{reviewers};
-        my $review      = first { $_->{reviewerPHID} eq $phab_user->phid } @$reviewers;
-        $diff->{fields}{review_status} = $review->{status};
-        push @result, $diff;
-    }
-    return \@result;
+    return $diffs->{result}{data};
 }
 
 1;

diff --git a/extensions/PhabBugz/lib/WebService.pm b/extensions/PhabBugz/lib/WebService.pm
index 5ca811d58f7410c7ea4de69132ab579508467c9d..0239ccf74036335e991e78590936b9c12240d022 100644 (file)
--- a/extensions/PhabBugz/lib/WebService.pm
+++ b/extensions/PhabBugz/lib/WebService.pm
@@ -116,7 +116,6 @@ sub needs_review {
     foreach my $review (@$reviews) {
         my $review_flat = {
             id     => $review->{id},
-            status => $review->{fields}{review_status},
             title  => $review->{fields}{title},
             url    => Bugzilla->params->{phabricator_base_uri} . 'D' . $review->{id},
         };