]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests: refactor the lsm `flags_overset_lsm_set_self_attr` test
authorAmit Vadhavana <av2082000@gmail.com>
Sat, 16 Nov 2024 15:21:36 +0000 (20:51 +0530)
committerPaul Moore <paul@paul-moore.com>
Wed, 18 Dec 2024 23:14:29 +0000 (18:14 -0500)
Remove the temporary context variable `tctx` to simplify the code. use
the original context `ctx` directly in calls to `lsm_get_self_attr`,
eliminating redundancy without any functional changes.

Reviewed-by: Casey Schaufler <casey@schaufler-ca.com>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Amit Vadhavana <av2082000@gmail.com>
[PM: subject tweak]
Signed-off-by: Paul Moore <paul@paul-moore.com>
tools/testing/selftests/lsm/lsm_set_self_attr_test.c

index 66dec47e3ca3f985f8947be22196b8a7e96b821e..732e89fe99c082085b71c65b1eacdb68dda5d91f 100644 (file)
@@ -56,16 +56,15 @@ TEST(flags_zero_lsm_set_self_attr)
 TEST(flags_overset_lsm_set_self_attr)
 {
        const long page_size = sysconf(_SC_PAGESIZE);
-       char *ctx = calloc(page_size, 1);
+       struct lsm_ctx *ctx = calloc(page_size, 1);
        __u32 size = page_size;
-       struct lsm_ctx *tctx = (struct lsm_ctx *)ctx;
 
        ASSERT_NE(NULL, ctx);
        if (attr_lsm_count()) {
-               ASSERT_LE(1, lsm_get_self_attr(LSM_ATTR_CURRENT, tctx, &size,
+               ASSERT_LE(1, lsm_get_self_attr(LSM_ATTR_CURRENT, ctx, &size,
                                               0));
        }
-       ASSERT_EQ(-1, lsm_set_self_attr(LSM_ATTR_CURRENT | LSM_ATTR_PREV, tctx,
+       ASSERT_EQ(-1, lsm_set_self_attr(LSM_ATTR_CURRENT | LSM_ATTR_PREV, ctx,
                                        size, 0));
 
        free(ctx);