]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cpuidle: psci: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 16 Aug 2024 15:09:28 +0000 (17:09 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 20 Aug 2024 09:30:39 +0000 (11:30 +0200)
Use scoped for_each_child_of_node_scoped() when iterating over device
nodes to make code a bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20240816150931.142208-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/cpuidle/cpuidle-psci-domain.c

index ea28b73ef3fb6c535dbf79739144f76431d48eef..146f9706802249ef3710e1928e4a53f0c1b3b8f1 100644 (file)
@@ -142,7 +142,6 @@ static const struct of_device_id psci_of_match[] = {
 static int psci_cpuidle_domain_probe(struct platform_device *pdev)
 {
        struct device_node *np = pdev->dev.of_node;
-       struct device_node *node;
        bool use_osi = psci_has_osi_support();
        int ret = 0, pd_count = 0;
 
@@ -153,15 +152,13 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
         * Parse child nodes for the "#power-domain-cells" property and
         * initialize a genpd/genpd-of-provider pair when it's found.
         */
-       for_each_child_of_node(np, node) {
+       for_each_child_of_node_scoped(np, node) {
                if (!of_property_present(node, "#power-domain-cells"))
                        continue;
 
                ret = psci_pd_init(node, use_osi);
-               if (ret) {
-                       of_node_put(node);
+               if (ret)
                        goto exit;
-               }
 
                pd_count++;
        }