]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mlxsw: spectrum_cnt: use bitmap_empty() in mlxsw_sp_counter_pool_fini()
authorYury Norov (NVIDIA) <yury.norov@gmail.com>
Sat, 13 Sep 2025 18:01:31 +0000 (14:01 -0400)
committerJakub Kicinski <kuba@kernel.org>
Tue, 16 Sep 2025 01:23:20 +0000 (18:23 -0700)
The function opencodes bitmap_empty(). Switch to the proper API in sake
of verbosity.

Signed-off-by: Yury Norov (NVIDIA) <yury.norov@gmail.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20250913180132.202593-1-yury.norov@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlxsw/spectrum_cnt.c

index 50e591420bd9d02b6777255ae6eeb65af7066592..b1094aaffa5f8d723fb6ff79432665bb9affee14 100644 (file)
@@ -170,8 +170,7 @@ void mlxsw_sp_counter_pool_fini(struct mlxsw_sp *mlxsw_sp)
        struct devlink *devlink = priv_to_devlink(mlxsw_sp->core);
 
        mlxsw_sp_counter_sub_pools_fini(mlxsw_sp);
-       WARN_ON(find_first_bit(pool->usage, pool->pool_size) !=
-                              pool->pool_size);
+       WARN_ON(!bitmap_empty(pool->usage, pool->pool_size));
        WARN_ON(atomic_read(&pool->active_entries_count));
        bitmap_free(pool->usage);
        devl_resource_occ_get_unregister(devlink,