gdb/reverse: Fix continue_to_breakpoint in syscall testcases.

continue_to_breakpoint always continues to the next breakpoint, not to the
one named in parameter.  This rendered the tests effectively useless, since
marker2 was never reached.

gdb/testsuite/ChangeLog:

	* gdb.reverse/fstatat-reverse.exp: Set breakpoint on marker1 after
	reaching marker2.
	* gdb.reverse/getresuid-reverse.exp: Likewise.
	* gdb.reverse/pipe-reverse.exp: Likewise.
	* gdb.reverse/readv-reverse.exp: Likewise.
	* gdb.reverse/recvmsg-reverse.exp: Likewise.
	* gdb.reverse/time-reverse.exp: Likewise.
	* gdb.reverse/waitpid-reverse.exp: Likewise and add KFAILs.

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index e01ee860a2274233aa9179b973491e89d8322cc9..ced4a87ce3005194a28481672d1e8492e79f583d 100644 (file)
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,14 @@
+2015-11-02  Marcin Kościelnicki  <koriakin@0x04.net>
+
+       * gdb.reverse/fstatat-reverse.exp: Set breakpoint on marker1 after
+       reaching marker2.
+       * gdb.reverse/getresuid-reverse.exp: Likewise.
+       * gdb.reverse/pipe-reverse.exp: Likewise.
+       * gdb.reverse/readv-reverse.exp: Likewise.
+       * gdb.reverse/recvmsg-reverse.exp: Likewise.
+       * gdb.reverse/time-reverse.exp: Likewise.
+       * gdb.reverse/waitpid-reverse.exp: Likewise and add KFAILs.
+
 2015-10-30  Yao Qi  <yao.qi@linaro.org>
 
        * gdb.threads/wp-replication.c (watch_count_done): Remove.

diff --git a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp
index 09deb6cb655a55eeaf6588a9e72be38d4c253a09..e9b2ca82f2f456504b9b279b4322ac18c65cbf72 100644 (file)
--- a/gdb/testsuite/gdb.reverse/fstatat-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/fstatat-reverse.exp
@@ -36,16 +36,16 @@ if [supports_process_record] {
     gdb_test_no_output "record" "Turn on process record"
 }
 
-gdb_test "break marker1" \
-    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
-    "set breakpoint at marker1"
-
 gdb_test "break marker2" \
     "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
     "set breakpoint at marker2"
 
 gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
 
+gdb_test "break marker1" \
+    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
+    "set breakpoint at marker1"
+
 gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
 
 # If the variable was recorded properly on syscall, the old contents (0)

diff --git a/gdb/testsuite/gdb.reverse/getresuid-reverse.exp b/gdb/testsuite/gdb.reverse/getresuid-reverse.exp
index b93fb91310764ca75493f94930b364c1fbb40c26..a625113ef3abe4c7cbc3df33fd5290dbf6be89a7 100644 (file)
--- a/gdb/testsuite/gdb.reverse/getresuid-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/getresuid-reverse.exp
@@ -36,16 +36,16 @@ if [supports_process_record] {
     gdb_test_no_output "record" "Turn on process record"
 }
 
-gdb_test "break marker1" \
-    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
-    "set breakpoint at marker1"
-
 gdb_test "break marker2" \
     "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
     "set breakpoint at marker2"
 
 gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
 
+gdb_test "break marker1" \
+    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
+    "set breakpoint at marker1"
+
 gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
 
 # If the variables were recorded properly on syscall, the old contents (-1)

diff --git a/gdb/testsuite/gdb.reverse/pipe-reverse.exp b/gdb/testsuite/gdb.reverse/pipe-reverse.exp
index 482893a23438976a2c4c00452ceefa850a67b900..5d5048823acb479922cd04a7058eae3d977993ca 100644 (file)
--- a/gdb/testsuite/gdb.reverse/pipe-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/pipe-reverse.exp
@@ -36,16 +36,16 @@ if [supports_process_record] {
     gdb_test_no_output "record" "Turn on process record"
 }
 
-gdb_test "break marker1" \
-    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
-    "set breakpoint at marker1"
-
 gdb_test "break marker2" \
     "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
     "set breakpoint at marker2"
 
 gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
 
+gdb_test "break marker1" \
+    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
+    "set breakpoint at marker1"
+
 gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
 
 # If the variables were recorded properly on syscall, the old contents (-1)

diff --git a/gdb/testsuite/gdb.reverse/readv-reverse.exp b/gdb/testsuite/gdb.reverse/readv-reverse.exp
index 4158c10671a9f40763611d927bdcaae68faf3427..c9178d92ec1e8d78a9615bd6844dc9d280b513e8 100644 (file)
--- a/gdb/testsuite/gdb.reverse/readv-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/readv-reverse.exp
@@ -36,16 +36,16 @@ if [supports_process_record] {
     gdb_test_no_output "record" "Turn on process record"
 }
 
-gdb_test "break marker1" \
-    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
-    "set breakpoint at marker1"
-
 gdb_test "break marker2" \
     "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
     "set breakpoint at marker2"
 
 gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
 
+gdb_test "break marker1" \
+    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
+    "set breakpoint at marker1"
+
 gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
 
 # If the variables were recorded properly on syscall, the old contents ("")

diff --git a/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp b/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp
index 7293a3d518462d578ab052f21b7bfc54806e502e..2540b91bc36aca7ce98557c8542a10eca1649e5b 100644 (file)
--- a/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/recvmsg-reverse.exp
@@ -36,16 +36,16 @@ if [supports_process_record] {
     gdb_test_no_output "record" "Turn on process record"
 }
 
-gdb_test "break marker1" \
-    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
-    "set breakpoint at marker1"
-
 gdb_test "break marker2" \
     "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
     "set breakpoint at marker2"
 
 gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
 
+gdb_test "break marker1" \
+    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
+    "set breakpoint at marker1"
+
 gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
 
 # If the variables were recorded properly on syscall, the old contents will

diff --git a/gdb/testsuite/gdb.reverse/time-reverse.exp b/gdb/testsuite/gdb.reverse/time-reverse.exp
index 9cec3c37e7fab591e6555ea0951bad2569bcf35a..1cc111b746bfcfddd7c175e843d0fb70234d5f0d 100644 (file)
--- a/gdb/testsuite/gdb.reverse/time-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/time-reverse.exp
@@ -36,16 +36,16 @@ if [supports_process_record] {
     gdb_test_no_output "record" "Turn on process record"
 }
 
-gdb_test "break marker1" \
-    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
-    "set breakpoint at marker1"
-
 gdb_test "break marker2" \
     "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
     "set breakpoint at marker2"
 
 gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
 
+gdb_test "break marker1" \
+    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
+    "set breakpoint at marker1"
+
 gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
 
 # If the variable was recorded properly on syscall, the old contents (-1)

diff --git a/gdb/testsuite/gdb.reverse/waitpid-reverse.exp b/gdb/testsuite/gdb.reverse/waitpid-reverse.exp
index f4a440365dfc7bbe8dbe245853bd591b13e86ec7..ddd8d7b80cf9326cc61b246036bfe4863d007546 100644 (file)
--- a/gdb/testsuite/gdb.reverse/waitpid-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/waitpid-reverse.exp
@@ -36,16 +36,18 @@ if [supports_process_record] {
     gdb_test_no_output "record" "Turn on process record"
 }
 
-gdb_test "break marker1" \
-    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
-    "set breakpoint at marker1"
-
 gdb_test "break marker2" \
     "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
     "set breakpoint at marker2"
 
+setup_kfail "gdb/19187" *-*-*
 gdb_continue_to_breakpoint "marker2" ".*$srcfile:.*"
 
+gdb_test "break marker1" \
+    "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \
+    "set breakpoint at marker1"
+
+setup_kfail "gdb/19187" *-*-*
 gdb_test "reverse-continue" ".*$srcfile:$decimal.*" "reverse to marker1"
 
 # If the variable was recorded properly on syscall, the old contents (-1)