mtd: spi-nor: hisi-sfc: Add of_node_put() before break

Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a break from the middle of the loop, there
is no put, thus causing a memory leak. Hence add an of_node_put before
the break.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>

diff --git a/drivers/mtd/spi-nor/hisi-sfc.c b/drivers/mtd/spi-nor/hisi-sfc.c
index dea43ea3eea39c20c71570fcc3becf2effc1d912..6dac9dd8bf42d1c8db866fb5cf24a41dc4ee5aad 100644 (file)
--- a/drivers/mtd/spi-nor/hisi-sfc.c
+++ b/drivers/mtd/spi-nor/hisi-sfc.c
@@ -401,6 +401,7 @@ static int hisi_spi_nor_register_all(struct hifmc_host *host)
 
                if (host->num_chip == HIFMC_MAX_CHIP_NUM) {
                        dev_warn(dev, "Flash device number exceeds the maximum chipselect number\n");
+                       of_node_put(np);
                        break;
                }
        }