]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
arm64: dts: qcom: x1e80100: Fix up BAR spaces
authorKonrad Dybcio <konrad.dybcio@linaro.org>
Wed, 10 Jul 2024 14:07:23 +0000 (16:07 +0200)
committerBjorn Andersson <andersson@kernel.org>
Thu, 24 Oct 2024 15:51:39 +0000 (10:51 -0500)
The 32-bit BAR spaces are reaching outside their assigned register
regions. Shrink them to match their actual sizes.

This resolves an issue where the regions overlap and one of the
controllers won't come up, which can be seen in the log as:

  qcom-pcie 1c08000.pci: resource collision: [mem 0x7c300000-0x7fffffff] conflicts with 1c00000.pci dbi [mem 0x7e000000-0x7e000f1c]

While at it, unify the style.

Fixes: 5eb83fc10289 ("arm64: dts: qcom: x1e80100: Add PCIe nodes")
Cc: stable@vger.kernel.org
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Tested-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20240710-topic-barman-v1-1-5f63fca8d0fc@linaro.org
[bjorn: Added note about overlapping resource regions]
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/x1e80100.dtsi

index 6a419fb6a982494039dbea02fb85602bf8d54397..c5d033e1b3457e71c4a4f056413260899f2d8285 100644 (file)
                                    "mhi";
                        #address-cells = <3>;
                        #size-cells = <2>;
-                       ranges = <0x01000000 0 0x00000000 0 0x70200000 0 0x100000>,
-                                <0x02000000 0 0x70300000 0 0x70300000 0 0x3d00000>;
-                       bus-range = <0 0xff>;
+                       ranges = <0x01000000 0x0 0x00000000 0x0 0x70200000 0x0 0x100000>,
+                                <0x02000000 0x0 0x70300000 0x0 0x70300000 0x0 0x1d00000>;
+                       bus-range = <0x00 0xff>;
 
                        dma-coherent;
 
                                    "mhi";
                        #address-cells = <3>;
                        #size-cells = <2>;
-                       ranges = <0x01000000 0 0x00000000 0 0x7c200000 0 0x100000>,
-                                <0x02000000 0 0x7c300000 0 0x7c300000 0 0x3d00000>;
+                       ranges = <0x01000000 0x0 0x00000000 0x0 0x7c200000 0x0 0x100000>,
+                                <0x02000000 0x0 0x7c300000 0x0 0x7c300000 0x0 0x1d00000>;
                        bus-range = <0x00 0xff>;
 
                        dma-coherent;