]> git.ipfire.org Git - thirdparty/shadow.git/commitdiff
lib/getrange.c: getrange(): Return early
authorAlejandro Colomar <alx@kernel.org>
Mon, 15 Apr 2024 09:57:49 +0000 (11:57 +0200)
committerSerge Hallyn <serge@hallyn.com>
Sat, 4 May 2024 22:22:57 +0000 (17:22 -0500)
It's doesn't make much sense to break from a switch() just to return.
Let's return early, to simplify.

Signed-off-by: Alejandro Colomar <alx@kernel.org>
lib/getrange.c

index 0410cb81f4467e95ca55383b37ff1848965e0d35..e5ea1744998a62e636b56552dc1587def32e8011 100644 (file)
@@ -59,10 +59,10 @@ getrange(const char *range,
 
        switch (*endptr) {
        case '\0':
-               /* <long> */
                *has_max = true;
                *max = *min;
-               break;
+               return 0;  /* <long> */
+
        case '-':
                endptr++;
                if ('\0' == *endptr)
@@ -76,11 +76,9 @@ getrange(const char *range,
                        return -1;
                *has_max = true;
 
-               /* <long>-<long> */
-               break;
+               return 0;  /* <long>-<long> */
+
        default:
                return -1;
        }
-
-       return 0;
 }