]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mfd: wm8994: Fix Wvoid-pointer-to-enum-cast warning (again)
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 6 Jun 2024 14:36:48 +0000 (16:36 +0200)
committerLee Jones <lee@kernel.org>
Thu, 4 Jul 2024 16:38:40 +0000 (17:38 +0100)
'type' is an enum, thus cast of pointer on 64-bit compile test with
clang and W=1 causes:

  wm8994-core.c:625:17: error: cast to smaller integer type 'enum wm8994_type' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]

Year ago this was solved, although LKML discussion suggested warning is
not suitable for kernel.  Nothing changed in this regard for a year, so
assume the warning will stay and we want to have warnings-free builds.

Link: https://lore.kernel.org/all/20230814160457.GA2836@dev-arch.thelio-3990X/
Link: https://lore.kernel.org/all/20230810095849.123321-1-krzysztof.kozlowski@linaro.org/
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20240606143648.152668-3-krzysztof.kozlowski@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/wm8994-core.c

index d5ac066f9db404c0e6b6f739c4198153f6871222..094c0b3dbd97d9d2161210eb1bdff8dbb4bb473e 100644 (file)
@@ -622,7 +622,7 @@ static int wm8994_i2c_probe(struct i2c_client *i2c)
        wm8994->dev = &i2c->dev;
        wm8994->irq = i2c->irq;
 
-       wm8994->type = (enum wm8994_type)i2c_get_match_data(i2c);
+       wm8994->type = (kernel_ulong_t)i2c_get_match_data(i2c);
 
        wm8994->regmap = devm_regmap_init_i2c(i2c, &wm8994_base_regmap_config);
        if (IS_ERR(wm8994->regmap)) {