]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
lib: Fix memory leak CID#1469247
authorVinit Agnihotri <vagnihot@redhat.com>
Tue, 12 Aug 2025 06:02:00 +0000 (11:32 +0530)
committerVolker Lendecke <vl@samba.org>
Fri, 15 Aug 2025 08:53:53 +0000 (08:53 +0000)
pointer 'p' gets duplicated in file_lines_parse(), but not free'd
before returning.

Signed-off-by: Vinit Agnihotri <vagnihot@redhat.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Fri Aug 15 08:53:53 UTC 2025 on atb-devel-224

source3/lib/util_file.c

index 5d6afc3c0b12d399d190f454589966d9f96830b0..21a6559fc439e709839f15a32de6db18e512ff9f 100644 (file)
@@ -178,11 +178,14 @@ char **file_lines_ploadv(TALLOC_CTX *mem_ctx,
 {
        char *p = NULL;
        size_t size;
+       char **ret = NULL;
 
        p = file_ploadv(argl, &size);
        if (!p) {
                return NULL;
        }
 
-       return file_lines_parse(p, size, numlines, mem_ctx);
+       ret = file_lines_parse(p, size, numlines, mem_ctx);
+       TALLOC_FREE(p);
+       return ret;
 }