]> git.ipfire.org Git - thirdparty/knot-resolver.git/commitdiff
selection: return early from forward_choose_transport with asserts off
authorŠtěpán Balážik <stepan.balazik@nic.cz>
Fri, 15 Jan 2021 11:52:02 +0000 (12:52 +0100)
committerŠtěpán Balážik <stepan.balazik@nic.cz>
Fri, 15 Jan 2021 11:52:02 +0000 (12:52 +0100)
This lead to unintitialized values being possibly used down the line.

lib/selection_forward.c

index 8125f887c03a928142ccdf66fe35fc01dba8ed8a..165aa53f445cfd2abd71836d256e8a590f6a04f8 100644 (file)
@@ -52,6 +52,8 @@ void forward_choose_transport(struct kr_query *qry,
                        break;
                default:
                        assert(0);
+                       *transport = NULL;
+                       return;
                }
 
                struct address_state *addr_state = &local_state->addr_states[i];