]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
Refrain from accessing empty smartlist in test_bridges_clear_bridge_list
authorrl1987 <rl1987@sdf.lonestar.org>
Sun, 3 Jun 2018 10:34:24 +0000 (13:34 +0300)
committerNick Mathewson <nickm@torproject.org>
Wed, 20 Jun 2018 11:49:41 +0000 (07:49 -0400)
Just check that smartlist length is zero instead

src/test/test_bridges.c

index c4a4cacd982ecc82f42b88b87a80e51db9f34f13..c44f791e0d6d27b0a7e21c9718c3a375fa1ad861 100644 (file)
@@ -140,7 +140,6 @@ test_bridges_clear_bridge_list(void *arg)
   const smartlist_t *bridgelist;
   const smartlist_t *bridgelist_after;
   const bridge_info_t *bridge;
-  const bridge_info_t *bridge_after;
 
   helper_add_bridges_to_bridgelist(arg);
   bridgelist = bridge_list_get();
@@ -152,10 +151,7 @@ test_bridges_clear_bridge_list(void *arg)
   clear_bridge_list();
   bridgelist_after = bridge_list_get();
   tt_ptr_op(bridgelist_after, OP_NE, NULL);
-
-  bridge_after = smartlist_get(bridgelist, 0);
-  // There now shouldn't be a first bridge
-  tt_ptr_op(bridge_after, OP_EQ, NULL);
+  tt_int_op(smartlist_len(bridgelist_after), OP_EQ, 0);
 
  done:
   return;