]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: cs35l34: drop useless rate contraint
authorJerome Brunet <jbrunet@baylibre.com>
Thu, 5 Sep 2024 14:13:03 +0000 (16:13 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 6 Sep 2024 07:23:55 +0000 (09:23 +0200)
The cs35l34 adds a useless rate constraint on startup.
It does not set SNDRV_PCM_RATE_KNOT and the rates set are already a subset
of the ones provided in the constraint list, so it is a no-op.

>From the rest of the code, it is likely HW supports more than the 32, 44.1
and 48kHz listed in CS35L34_RATES but there is no way to know for sure
without proper documentation.

Keep the driver as it is for now and just drop the useless constraint.

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Reviewed-by: David Rhodes <drhodes@opensource.cirrus.com>
Acked-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20240905-alsa-12-24-128-v1-12-8371948d3921@baylibre.com
sound/soc/codecs/cs35l34.c

index e63a518e3b8e04ecf4d57c6fad7625f10af32147..287b27476a10922cbe68d6fcaa2a6063e9b5541b 100644 (file)
@@ -562,26 +562,6 @@ static int cs35l34_pcm_hw_params(struct snd_pcm_substream *substream,
        return ret;
 }
 
-static const unsigned int cs35l34_src_rates[] = {
-       8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000
-};
-
-
-static const struct snd_pcm_hw_constraint_list cs35l34_constraints = {
-       .count  = ARRAY_SIZE(cs35l34_src_rates),
-       .list   = cs35l34_src_rates,
-};
-
-static int cs35l34_pcm_startup(struct snd_pcm_substream *substream,
-                              struct snd_soc_dai *dai)
-{
-
-       snd_pcm_hw_constraint_list(substream->runtime, 0,
-                               SNDRV_PCM_HW_PARAM_RATE, &cs35l34_constraints);
-       return 0;
-}
-
-
 static int cs35l34_set_tristate(struct snd_soc_dai *dai, int tristate)
 {
 
@@ -639,7 +619,6 @@ static int cs35l34_dai_set_sysclk(struct snd_soc_dai *dai,
 }
 
 static const struct snd_soc_dai_ops cs35l34_ops = {
-       .startup = cs35l34_pcm_startup,
        .set_tristate = cs35l34_set_tristate,
        .set_fmt = cs35l34_set_dai_fmt,
        .hw_params = cs35l34_pcm_hw_params,